Skip to content

SMS Enhancements and minor fixes #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Apr 16, 2024
Merged

SMS Enhancements and minor fixes #9

merged 25 commits into from
Apr 16, 2024

Conversation

sebromero
Copy link
Contributor

@sebromero sebromero commented Apr 12, 2024 •
edited
Loading

  • Add support for newlines in SMS messages
  • Add index property to SMS
  • Fix date parsing (Year was not interpreted correctly)
  • Add polling mechanism to SMS receive example
  • Remove need to supply APN settings for SMS tasks
  • Add option for deleting SMS
  • Add option to enable debug prints
  • Avoid need to connect to GPRS for SMS tasks

@github-actions GitHub Actions
Copy link

Memory usage change @ 0f7a7ab

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 ❔ -32 - +656 -0.0 - +0.03 🔺 0 - +8 0.0 - 0.0
Click for full report table
Board examples/HTTPClient
flash		 % examples/HTTPClient
RAM for global variables		 % examples/HTTPSClient
flash		 % examples/HTTPSClient
RAM for global variables		 % examples/TimeAndLocation
flash		 % examples/TimeAndLocation
RAM for global variables		 % examples/ReceiveSMS
flash		 % examples/ReceiveSMS
RAM for global variables		 % examples/SendSMS
flash		 % examples/SendSMS
RAM for global variables		 %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 344 0.02 0 0.0 352 0.02 0 0.0 -32 -0.0 0 0.0 656 0.03 8 0.0 224 0.01 0 0.0
Click for full report CSV 
Board,examples/HTTPClient<br>flash,%,examples/HTTPClient<br>RAM for global variables,%,examples/HTTPSClient<br>flash,%,examples/HTTPSClient<br>RAM for global variables,%,examples/TimeAndLocation<br>flash,%,examples/TimeAndLocation<br>RAM for global variables,%,examples/ReceiveSMS<br>flash,%,examples/ReceiveSMS<br>RAM for global variables,%,examples/SendSMS<br>flash,%,examples/SendSMS<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,344,0.02,0,0.0,352,0.02,0,0.0,-32,-0.0,0,0.0,656,0.03,8,0.0,224,0.01,0,0.0

@github-actions GitHub Actions
Copy link

Memory usage change @ 5e5a377

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 ❔ -32 - +656 -0.0 - +0.03 🔺 0 - +8 0.0 - 0.0
Click for full report table
Board examples/HTTPClient
flash		 % examples/HTTPClient
RAM for global variables		 % examples/HTTPSClient
flash		 % examples/HTTPSClient
RAM for global variables		 % examples/TimeAndLocation
flash		 % examples/TimeAndLocation
RAM for global variables		 % examples/ReceiveSMS
flash		 % examples/ReceiveSMS
RAM for global variables		 % examples/SendSMS
flash		 % examples/SendSMS
RAM for global variables		 %
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 344 0.02 0 0.0 352 0.02 0 0.0 -32 -0.0 0 0.0 656 0.03 8 0.0 224 0.01 0 0.0
Click for full report CSV 
Board,examples/HTTPClient<br>flash,%,examples/HTTPClient<br>RAM for global variables,%,examples/HTTPSClient<br>flash,%,examples/HTTPSClient<br>RAM for global variables,%,examples/TimeAndLocation<br>flash,%,examples/TimeAndLocation<br>RAM for global variables,%,examples/ReceiveSMS<br>flash,%,examples/ReceiveSMS<br>RAM for global variables,%,examples/SendSMS<br>flash,%,examples/SendSMS<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,344,0.02,0,0.0,352,0.02,0,0.0,-32,-0.0,0,0.0,656,0.03,8,0.0,224,0.01,0,0.0

@sebromero sebromero marked this pull request as ready for review April 15, 2024 16:29
@cristidragomir97
Copy link
Contributor

Looks good to me, all additions tested

@cristidragomir97 cristidragomir97 merged commit 5612288 into main Apr 16, 2024
5 of 10 checks passed
@cristidragomir97 cristidragomir97 deleted the various-fixes branch April 16, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristidragomir97 cristidragomir97 Awaiting requested review from cristidragomir97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebromero @cristidragomir97